Skip to content

ci: build with Node 26 LTS, read from .nvmrc - #16

Open
imdt-claudiop wants to merge 3 commits into
bigbluebutton:v0.1.xfrom
imdt-claudiop:chore/node-26
Open

imdt-claudiop wants to merge 3 commits into
bigbluebutton:v0.1.xfrom
imdt-claudiop:chore/node-26

Conversation

@imdt-claudiop

Copy link
Copy Markdown
Contributor

Moves CI from Node 24 to Node 26, the current LTS line (26.13.0, released 2026-10-28, is the first LTS release of the 26 line), and makes .nvmrc the single place that sets the Node version for every workflow. The next version bump becomes a one-line change to .nvmrc.

What changes

  • .nvmrc (new): 26
  • .github/workflows/publish-tag.yml: node-version: '24' -> node-version-file: '.nvmrc'
  • .github/workflows/ts-code-compilation.yml: node-version: 24.x -> node-version-file: '.nvmrc'
  • .github/workflows/ts-code-validation.yml: node-version: 24.x -> node-version-file: '.nvmrc'
  • .github/workflows/build-plugin-deb-package.yml: the NodeSource install step no longer hardcodes setup_24.x. It reads the major version from .nvmrc and installs setup_${NODE_MAJOR}.x, failing the step with an explicit error if .nvmrc does not hold a numeric major (for example lts/*), instead of silently falling back to the distribution's nodejs.

The engines floor in package.json (>=22), debian/control, package-lock.json and @types/node are left as they are: this change only moves the Node version CI uses and where it is declared.

Testing

Locally on top of v0.1.x, with the Node version taken from .nvmrc (26.13.0, npm 11.20.0):

  • npm ci: pass
  • npx tsc: pass
  • npm run lint: pass
  • npm run build-bundle: pass

Workflows:

  • every workflow file parses as YAML, and every actions/setup-node step uses node-version-file: '.nvmrc'
  • actionlint 1.7.12 reports no new findings compared with v0.1.x (the existing ones are about older action versions, untouched here)
  • the Debian install snippet, run in bash: .nvmrc values 26, v26 and 26.13.0 resolve to setup_26.x (which answers 200 on NodeSource); lts/* and an empty file fail the step with the error message

The Debian package workflow and publish-tag were not run end to end.

Move every Node.js version pinned in the GitHub workflows (and .nvmrc where present) to 26, the current LTS line. The engines floor in package.json is left unchanged.
Every workflow that installs Node now takes the version from .nvmrc: actions/setup-node uses node-version-file, and the Debian package workflow reads the major version for the NodeSource setup script (failing the step if .nvmrc does not hold a numeric major). The next version bump is a one-line change to .nvmrc.
The switch to node-version-file dropped the blank line that separated the Node setup step from the next one. Formatting only, no change in behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant