Repository navigation
ci: build with Node 26 LTS, read from .nvmrc - #16
Open
imdt-claudiop wants to merge 3 commits into
Open
imdt-claudiop wants to merge 3 commits into
imdt-claudiop wants to merge 3 commits into
Conversation
Move every Node.js version pinned in the GitHub workflows (and .nvmrc where present) to 26, the current LTS line. The engines floor in package.json is left unchanged.
Every workflow that installs Node now takes the version from .nvmrc: actions/setup-node uses node-version-file, and the Debian package workflow reads the major version for the NodeSource setup script (failing the step if .nvmrc does not hold a numeric major). The next version bump is a one-line change to .nvmrc.
The switch to node-version-file dropped the blank line that separated the Node setup step from the next one. Formatting only, no change in behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves CI from Node 24 to Node 26, the current LTS line (26.13.0, released 2026-10-28, is the first LTS release of the 26 line), and makes
.nvmrcthe single place that sets the Node version for every workflow. The next version bump becomes a one-line change to.nvmrc.What changes
.nvmrc(new):26.github/workflows/publish-tag.yml:node-version: '24'->node-version-file: '.nvmrc'.github/workflows/ts-code-compilation.yml:node-version: 24.x->node-version-file: '.nvmrc'.github/workflows/ts-code-validation.yml:node-version: 24.x->node-version-file: '.nvmrc'.github/workflows/build-plugin-deb-package.yml: the NodeSource install step no longer hardcodessetup_24.x. It reads the major version from.nvmrcand installssetup_${NODE_MAJOR}.x, failing the step with an explicit error if.nvmrcdoes not hold a numeric major (for examplelts/*), instead of silently falling back to the distribution'snodejs.The
enginesfloor inpackage.json(>=22),debian/control,package-lock.jsonand@types/nodeare left as they are: this change only moves the Node version CI uses and where it is declared.Testing
Locally on top of
v0.1.x, with the Node version taken from.nvmrc(26.13.0, npm 11.20.0):npm ci: passnpx tsc: passnpm run lint: passnpm run build-bundle: passWorkflows:
actions/setup-nodestep usesnode-version-file: '.nvmrc'actionlint1.7.12 reports no new findings compared withv0.1.x(the existing ones are about older action versions, untouched here).nvmrcvalues26,v26and26.13.0resolve tosetup_26.x(which answers 200 on NodeSource);lts/*and an empty file fail the step with the error messageThe Debian package workflow and
publish-tagwere not run end to end.